-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SQL][CORE] SPARK-2102 #1377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SQL][CORE] SPARK-2102 #1377
Conversation
|
Can one of the admins verify this patch? |
|
test this please |
|
QA tests have started for PR 1377. This patch merges cleanly. |
|
QA results for PR 1377: |
|
@pwendell, any thoughts on the additional option for kryo? |
docs/configuration.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ianoc - I found the wording here a bit confusing when reading it over. It would be good to say the exact behavior of Kryo if this is set to true (i.e. will it throw an exception if an unregistered class is found?). Also, the this in the third sentence, it's a bit ambigugous whether that refers to the registration itself or the default setting of this value. A slight re-word would be :
Whether to require registration with Kryo. If set to 'true', Kryo will throw an exception
if an unregistered class is serialized. If set to false (the default), Kryo will write
unregistered class names along with each object. Writing class names can cause
significant performance overhead, so enabling this option can enforce strictly that a
user has not omitted classes from registration.
|
@pwendell Sounds good to me, updated as per your suggestion. |
|
test this please |
|
QA tests have started for PR 1377. This patch merges cleanly. |
|
QA results for PR 1377: |
|
Thanks! I've merged this into master. |
|
Excellent thanks |
… use a resource pool in Spark SQL for Kryo instances. Author: Ian O Connell <[email protected]> Closes apache#1377 from ianoc/feature/SPARK-2102 and squashes the following commits: 5498566 [Ian O Connell] Docs update suggested by Patrick 20e8555 [Ian O Connell] Slight style change f92c294 [Ian O Connell] Add docs for new KryoSerializer option f3735c8 [Ian O Connell] Add using a kryo resource pool for the SqlSerializer 4e5c342 [Ian O Connell] Register the SparkConf for kryo, it gets swept into serialization 665805a [Ian O Connell] Add a spark.kryo.registrationRequired option for configuring the Kryo Serializer
Adds in an option into the kryo serializer to enable requiring registration
Adds a resource pool in the SparkSqlSerializer code paths to speed up serialization of generic types.