Skip to content

replace println to log4j #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

replace println to log4j #1372

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa22a38
replace println to log4j
fireflyc Jul 11, 2014
e684140
'info' modified into the 'debug'
fireflyc Jul 16, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions streaming/src/main/scala/org/apache/spark/streaming/receiver/ActorReceiver.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,13 @@ object ActorSupervisorStrategy {
* should be same.
*/
@DeveloperApi
trait ActorHelper {
trait ActorHelper extends Logging{
Copy link
Contributor

@aarondav aarondav Jul 12, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to prior comments about logDebug/removing -- as an additional nit, please put a space after Logging.


self: Actor => // to ensure that this can be added to Actor classes only

/** Store an iterator of received data as a data block into Spark's memory. */
def store[T](iter: Iterator[T]) {
println("Storing iterator")
logDebug("Storing iterator")
context.parent ! IteratorData(iter)
}

Expand All @@ -84,6 +84,7 @@ trait ActorHelper {
* that Spark is configured to use.
*/
def store(bytes: ByteBuffer) {
logDebug("Storing Bytes")
context.parent ! ByteBufferData(bytes)
}

Expand All @@ -93,7 +94,7 @@ trait ActorHelper {
* being pushed into Spark's memory.
*/
def store[T](item: T) {
println("Storing item")
logDebug("Storing item")
context.parent ! SingleItemData(item)
}
}
Expand Down Expand Up @@ -157,15 +158,16 @@ private[streaming] class ActorReceiver[T: ClassTag](
def receive = {

case IteratorData(iterator) =>
println("received iterator")
logDebug("received iterator")
store(iterator.asInstanceOf[Iterator[T]])

case SingleItemData(msg) =>
println("received single")
logDebug("received single")
store(msg.asInstanceOf[T])
n.incrementAndGet

case ByteBufferData(bytes) =>
logDebug("received bytes")
store(bytes)

case props: Props =>
Expand Down