From d4078463d1937217d2b167c1cd370074efb62d8d Mon Sep 17 00:00:00 2001 From: Josh Rosen Date: Wed, 8 Jun 2016 11:58:56 -0700 Subject: [PATCH 1/2] Add staging repository for forked POM reader. --- project/plugins.sbt | 11 ++++++++++ project/project/SparkPluginBuild.scala | 28 -------------------------- 2 files changed, 11 insertions(+), 28 deletions(-) delete mode 100644 project/project/SparkPluginBuild.scala diff --git a/project/plugins.sbt b/project/plugins.sbt index 4578b56247aa9..d3412ff211498 100644 --- a/project/plugins.sbt +++ b/project/plugins.sbt @@ -21,3 +21,14 @@ libraryDependencies += "org.ow2.asm" % "asm" % "5.0.3" libraryDependencies += "org.ow2.asm" % "asm-commons" % "5.0.3" addSbtPlugin("com.simplytyped" % "sbt-antlr4" % "0.7.11") + +// Spark uses a custom fork of the sbt-pom-reader plugin which contains a patch to fix issues +// related to test-jar dependencies (https://github.com/sbt/sbt-pom-reader/pull/14). The source for +// this fork is published at https://github.com/JoshRosen/sbt-pom-reader/tree/v1.0.0-spark +// and corresponds to commit b160317fcb0b9d1009635a7c5aa05d0f3be61936 in that repository. +// In the long run, we should try to merge our patch upstream and switch to an upstream version of +// the plugin; this is tracked at SPARK-14401. + +resolvers += "Spark fork of sbt-pom-reader" at "https://oss.sonatype.org/content/repositories/orgspark-project-1124" + +addSbtPlugin("org.spark-project" % "sbt-pom-reader" % "1.0.0-spark") diff --git a/project/project/SparkPluginBuild.scala b/project/project/SparkPluginBuild.scala deleted file mode 100644 index cbb88dc7dd1dd..0000000000000 --- a/project/project/SparkPluginBuild.scala +++ /dev/null @@ -1,28 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed with - * this work for additional information regarding copyright ownership. - * The ASF licenses this file to You under the Apache License, Version 2.0 - * (the "License"); you may not use this file except in compliance with - * the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -import sbt._ -import sbt.Keys._ - -/** - * This plugin project is there because we use our custom fork of sbt-pom-reader plugin. This is - * a plugin project so that this gets compiled first and is available on the classpath for SBT build. - */ -object SparkPluginDef extends Build { - lazy val root = Project("plugins", file(".")) dependsOn(sbtPomReader) - lazy val sbtPomReader = uri("https://github.com/ScrapCodes/sbt-pom-reader.git#ignore_artifact_id") -} From 57199a84a97ad8d324a350e5e71f3888da5a2772 Mon Sep 17 00:00:00 2001 From: Josh Rosen Date: Wed, 8 Jun 2016 20:10:20 -0700 Subject: [PATCH 2/2] Update plugins.sbt --- project/plugins.sbt | 2 -- 1 file changed, 2 deletions(-) diff --git a/project/plugins.sbt b/project/plugins.sbt index d3412ff211498..8bebd7bcac58c 100644 --- a/project/plugins.sbt +++ b/project/plugins.sbt @@ -29,6 +29,4 @@ addSbtPlugin("com.simplytyped" % "sbt-antlr4" % "0.7.11") // In the long run, we should try to merge our patch upstream and switch to an upstream version of // the plugin; this is tracked at SPARK-14401. -resolvers += "Spark fork of sbt-pom-reader" at "https://oss.sonatype.org/content/repositories/orgspark-project-1124" - addSbtPlugin("org.spark-project" % "sbt-pom-reader" % "1.0.0-spark")