Skip to content

SPARK-2115: Stage kill link is too close to stage details link #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

SPARK-2115: Stage kill link is too close to stage details link #1350

wants to merge 1 commit into from

Conversation

@tsudukim
Copy link
Contributor

@tsudukim tsudukim commented Jul 10, 2014

Moved (kill) link to the right side. Add confirmation dialog when (kill) link is clicked.

@tsudukim
Moved (kill) link to the right side.
e2263b0 
Add confirmation dialog when (kill) link is clicked.
@AmplabJenkins
Copy link

AmplabJenkins commented Jul 10, 2014

Can one of the admins verify this patch?

@tsudukim
Copy link
Contributor Author

tsudukim commented Jul 10, 2014

Modified image is as followings:
spark-2115-img1
spark-2115-img2

@andrewor14
Copy link
Contributor

andrewor14 commented Jul 10, 2014

Looks good. @tsudukim did you accidentally kill a stage or something?

@tsudukim
Copy link
Contributor Author

tsudukim commented Jul 10, 2014

I nearly misclicked many times when I tried to go to the stage detail page.
And of course, you can kill the stage by clicking the OK button at confirmation dialog yet.

@rxin
Copy link
Contributor

rxin commented Jul 10, 2014

Jenkins, test this please.

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 10, 2014

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 10, 2014

Merged build started.

@SparkQA
Copy link

SparkQA commented Jul 10, 2014

QA tests have started for PR 1350. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16491/consoleFull

@SparkQA
Copy link

SparkQA commented Jul 10, 2014

QA results for PR 1350:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16491/consoleFull

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 10, 2014

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 10, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16491/

@rxin
Copy link
Contributor

rxin commented Jul 10, 2014

Thanks - merging this in master.

@asfgit asfgit closed this in c2babc0 Jul 10, 2014
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@tsudukim @conviva-zz
SPARK-2115: Stage kill link is too close to stage details link
1c3265a 
Moved (kill) link to the right side. Add confirmation dialog when (kill) link is clicked.

Author: Masayoshi TSUZUKI <[email protected]>

Closes apache#1350 from tsudukim/feature/SPARK-2115 and squashes the following commits:

e2263b0 [Masayoshi TSUZUKI] Moved (kill) link to the right side. Add confirmation dialog when (kill) link is clicked.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tsudukim @AmplabJenkins @andrewor14 @rxin @SparkQA