Skip to content

Conversation

@srowen
Copy link
Member

@srowen srowen commented May 11, 2016

What changes were proposed in this pull request?

Here I'm seeing if we can close stale PRs via a PR message, as I'd expect.
See thread https://www.mail-archive.com/[email protected]/msg14149.html

Closes #9354
Closes #9451
Closes #10507
Closes #10486
Closes #10460
Closes #10967
Closes #10681
Closes #11766
Closes #9907
Closes #10209
Closes #10379
Closes #10403
Closes #10842
Closes #11036
Closes #13003
Closes #10887

How was this patch tested?

(No changes)

@HyukjinKwon
Copy link
Member

+1

@HyukjinKwon
Copy link
Member

Do you mind adding #13003 maybe?

@SparkQA
Copy link

SparkQA commented May 11, 2016

Test build #58375 has finished for PR 13052 at commit b81422f.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member Author

srowen commented May 11, 2016

@HyukjinKwon that's already in the description. I'm ignoring the failure since there is no change to anything at all here.

@srowen
Copy link
Member Author

srowen commented May 12, 2016

Merged to master. Let's see if it worked.

@asfgit asfgit closed this in 5bb62b8 May 12, 2016
@srowen
Copy link
Member Author

srowen commented May 12, 2016

PS for anyone who tries this -- it does work, but to make the merge script work with an empty commit, its git commit command needs --allow-empty. I didn't actually suggest changing the script since we generally don't want to allow that, I think.

@srowen srowen deleted the TestClosingPRs branch May 12, 2016 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants