[SPARK-14462][ML][MLLIB] Add the mllib-local build to maven pom #12298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
April 8, 2016 00:28
Fix MiMa Addressed some of feedback Modifying sparktestsupport/modules.py for build server fix a bug Fix the build Ignore org.apache.spark.SparkException from MiMa
|
Test build #55518 has finished for PR 12298 at commit
|
Contributor
|
LGTM. Merged into master. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In order to separate the linear algebra, and vector matrix classes into a standalone jar, we need to setup the build first. This PR will create a new jar called mllib-local with minimal dependencies.
The previous PR was failing the build because of
spark-core:testdependency, and that was reverted. In this PR,FunSuitewith// scalastyle:ignore funsuitein mllib-local test was used, similar to sketch.Thanks.
How was this patch tested?
Unit tests
@mengxr @tedyu @holdenk