[SPARK-14429] [SQL] Improve LIKE pattern in "SHOW TABLES / FUNCTIONS LIKE <pattern>" DDL #12206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #55114 has finished for PR 12206 at commit
|
| subPattern => | ||
| try { | ||
| val regex = ("(?i)" + subPattern.replaceAll("\\*", ".*")).r | ||
| funcNames ++= names.filter{name => regex.pattern.matcher(name).matches()} |
Contributor
There was a problem hiding this comment.
style: filter { name => ... }
Contributor
|
LGTM, just a few style nits |
Contributor
|
I'll fix those myself on merge actually. Merging into master. |
Contributor
Author
|
@andrewor14 Cool, thanks. I will pay more attention to the coding style next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
LIKE is commonly used in SHOW TABLES / FUNCTIONS etc DDL. In the pattern, user can use
|or*as wildcards.replaceAll()to replace*with.*, but the replacement was scattered in several places; I have created an utility method and use it in all the places;SHOW TABLES LIKE ' T* 'will list all the t-tables. Please use Hive to verify it.|, the result will be sorted. For pattern like' B*|a* ', it will list the result in a-b order.I've made some changes to the utility method to make sure we will get the same result as Hive does.
How was this patch tested?
A new method was created in StringUtil and test cases were added.
@andrewor14