[SPARK-14345][SQL] Decouple deserializer expression resolution from ObjectOperator #12131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
| /** | ||
| * Replace the [[UpCast]] expression by [[Cast]], and throw exceptions if the cast may truncate. | ||
| */ | ||
| object ResolveUpCast extends Rule[LogicalPlan] { |
Contributor
Author
There was a problem hiding this comment.
Move rules related to deserializer expressions together.
|
Test build #54775 has finished for PR 12131 at commit
|
|
Test build #54776 has finished for PR 12131 at commit
|
|
Test build #54804 has finished for PR 12131 at commit
|
|
Test build #54927 has finished for PR 12131 at commit
|
Contributor
|
LGTM, thanks for improving the comments. Its much clearer to me what is happing now!] Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR decouples deserializer expression resolution from
ObjectOperator, so that we can use deserializer expression in normal operators. This is needed by #12061 and #12067 , I abstracted the logic out and put them in this PR to reduce code change in the future.How was this patch tested?
existing tests.