From 58514e73352a47579cf56e921172924245356c61 Mon Sep 17 00:00:00 2001 From: Francois Prunier Date: Thu, 17 Mar 2016 16:29:08 +0100 Subject: [PATCH 1/2] making StructField nullable field documentation clearer --- .../main/scala/org/apache/spark/sql/types/StructField.scala | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructField.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructField.scala index 83570a5eaee61..e36da3808755f 100644 --- a/sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructField.scala +++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructField.scala @@ -24,7 +24,9 @@ import org.json4s.JsonDSL._ * A field inside a StructType. * @param name The name of this field. * @param dataType The data type of this field. - * @param nullable Indicates if values of this field can be `null` values. + * @param nullable Indicates if values of this field can be `null` values. Note that this ONLY A HINT to the + * optimiser, the calling code is responsible for ensuring that there is no null. It is NOT + * a constraint that will be checked by the engine. * @param metadata The metadata of this field. The metadata should be preserved during * transformation if the content of the column is not modified, e.g, in selection. */ From 2f986682b9c4bf9490b3c29d194e191067d21be6 Mon Sep 17 00:00:00 2001 From: Francois Prunier Date: Thu, 17 Mar 2016 16:41:33 +0100 Subject: [PATCH 2/2] typo --- .../src/main/scala/org/apache/spark/sql/types/StructField.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructField.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructField.scala index e36da3808755f..e35f166863f25 100644 --- a/sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructField.scala +++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructField.scala @@ -24,7 +24,7 @@ import org.json4s.JsonDSL._ * A field inside a StructType. * @param name The name of this field. * @param dataType The data type of this field. - * @param nullable Indicates if values of this field can be `null` values. Note that this ONLY A HINT to the + * @param nullable Indicates if values of this field can be `null` values. Note that this is ONLY A HINT to the * optimiser, the calling code is responsible for ensuring that there is no null. It is NOT * a constraint that will be checked by the engine. * @param metadata The metadata of this field. The metadata should be preserved during