Skip to content

[SPARK-2191][SQL] Make sure InsertIntoHiveTable doesn't execute more than once. #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-2191][SQL] Make sure InsertIntoHiveTable doesn't execute more than once. #1129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5128fe2
Make sure InsertIntoHiveTable doesn't execute each time you ask for i…
marmbrus Jun 19, 2014
9c6d9e4
Fix typo.
marmbrus Jun 19, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/hiveOperators.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,12 +344,16 @@ case class InsertIntoHiveTable(
writer.commitJob()
}

override def execute() = result

/**
* Inserts all the rows in the table into Hive. Row objects are properly serialized with the
* `org.apache.hadoop.hive.serde2.SerDe` and the
* `org.apache.hadoop.mapred.OutputFormat` provided by the table definition.
*
* Note: this is run once and then kept to avoid double insertions.
*/
def execute() = {
private lazy val result: RDD[Row] = {
val childRdd = child.execute()
assert(childRdd != null)

Expand Down
6 changes: 6 additions & 0 deletions sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,12 @@ import org.apache.spark.sql.{SchemaRDD, execution, Row}
*/
class HiveQuerySuite extends HiveComparisonTest {

test("CREATE TABLE AS runs once") {
hql("CREATE TABLE foo AS SELECT 1 FROM src LIMIT 1").collect()
assert(hql("SELECT COUNT(*) FROM foo").collect().head.getLong(0) === 1,
"Incorrect number of rows in created table")
}

createQueryTest("between",
"SELECT * FROM src WHERE key Between 1 and 2")

Expand Down