Skip to content

Conversation

@viirya
Copy link
Member

@viirya viirya commented Dec 24, 2015

This patch refactors the filter pushdown for JDBCRDD and also adds few filters.

Added filters are basically from #10468 with some refactoring. Test cases are from #10468.

@viirya
Copy link
Member Author

viirya commented Dec 24, 2015

retest this please.

@SparkQA
Copy link

SparkQA commented Dec 24, 2015

Test build #48302 has finished for PR 10470 at commit 05188b7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 24, 2015

Test build #48303 has finished for PR 10470 at commit 05188b7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to update this comment

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok.

@rxin
Copy link
Contributor

rxin commented Dec 29, 2015

@maropu can you review this change?

@SparkQA
Copy link

SparkQA commented Dec 29, 2015

Test build #48408 has finished for PR 10470 at commit b0da6fc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the old code here is a lot easier to understand than the new version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 and the old one is better to me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. I revert it back to old code with little difference for the new filterWhereClause.

@maropu
Copy link
Member

maropu commented Dec 30, 2015

@rxin Okay and I did.

@SparkQA
Copy link

SparkQA commented Dec 30, 2015

Test build #48449 has finished for PR 10470 at commit a7ef79e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Dec 30, 2015

@viirya I've merged #10468 now.

@viirya
Copy link
Member Author

viirya commented Dec 31, 2015

@rxin Rebased. Wait for passing tests.

@SparkQA
Copy link

SparkQA commented Dec 31, 2015

Test build #48534 has finished for PR 10470 at commit cb7ce21.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member Author

viirya commented Jan 1, 2016

ping @rxin

@rxin
Copy link
Contributor

rxin commented Jan 1, 2016

Thanks - I've merged this.

@asfgit asfgit closed this in ad5b7cf Jan 1, 2016
zzcclp added a commit to zzcclp/spark that referenced this pull request Jul 27, 2016
@viirya viirya deleted the refactor-jdbc-filter branch December 27, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants