-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-12409][SPARK-12387][SPARK-12391][SQL] Refactor filter pushdown for JDBCRDD and add few filters #10470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
retest this please. |
|
Test build #48302 has finished for PR 10470 at commit
|
|
Test build #48303 has finished for PR 10470 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to update this comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok.
|
@maropu can you review this change? |
|
Test build #48408 has finished for PR 10470 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the old code here is a lot easier to understand than the new version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 and the old one is better to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. I revert it back to old code with little difference for the new filterWhereClause.
|
@rxin Okay and I did. |
|
Test build #48449 has finished for PR 10470 at commit
|
|
@rxin Rebased. Wait for passing tests. |
|
Test build #48534 has finished for PR 10470 at commit
|
|
ping @rxin |
|
Thanks - I've merged this. |
…hdown for JDBCRDD and add few filters apache#10470
This patch refactors the filter pushdown for JDBCRDD and also adds few filters.
Added filters are basically from #10468 with some refactoring. Test cases are from #10468.