Skip to content

Conversation

@lw-lin
Copy link
Contributor

@lw-lin lw-lin commented Dec 15, 2015

…endly Receiver graphs

Currently, the Spark Streaming web UI uses the same maxY when displays 'Input Rate Times& Histograms' and 'Per-Receiver Times& Histograms'.

This may lead to somewhat un-friendly graphs: once we have tens of Receivers or more, every 'Per-Receiver Times' line almost hits the ground.

This issue proposes to calculate a new maxY against the original one, which is shared among all the `Per-Receiver Times& Histograms' graphs.

Before:
before-5

After:
after-5

@lw-lin
Copy link
Contributor Author

lw-lin commented Dec 15, 2015

@zsxwing could you take a look at this again, please? :-)

@zsxwing
Copy link
Member

zsxwing commented Dec 16, 2015

Jenkins, test this please

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove sortBy?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zsxwing By mistake; gonna add it back.

@zsxwing
Copy link
Member

zsxwing commented Dec 16, 2015

LGTM pending tests

@zsxwing
Copy link
Member

zsxwing commented Dec 16, 2015

retest this please

@SparkQA
Copy link

SparkQA commented Dec 16, 2015

Test build #47760 has finished for PR 10318 at commit 9882333.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zsxwing
Copy link
Member

zsxwing commented Dec 16, 2015

retest this please

@SparkQA
Copy link

SparkQA commented Dec 16, 2015

Test build #47769 has finished for PR 10318 at commit cc05131.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zsxwing
Copy link
Member

zsxwing commented Dec 16, 2015

Thanks @proflin, merging to master

@asfgit asfgit closed this in d52bf47 Dec 16, 2015
@lw-lin
Copy link
Contributor Author

lw-lin commented Dec 16, 2015

@zsxwing Thanks for reviewing and merging so soon. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants