Skip to content

[SPARK-12275][SQL] No plan for BroadcastHint in some condition #10265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-12275][SQL] No plan for BroadcastHint in some condition #10265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ced744
[SPARK-12275][SQL] No plan for BroadcastHint in some condition
Dec 10, 2015
1b8d570
Add test cases
Dec 11, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ private[sql] abstract class SparkStrategies extends QueryPlanner[SparkPlan] {
case e @ EvaluatePython(udf, child, _) =>
BatchPythonEvaluation(udf, e.output, planLater(child)) :: Nil
case LogicalRDD(output, rdd) => PhysicalRDD(output, rdd, "ExistingRDD") :: Nil
case BroadcastHint(child) => apply(child)
case BroadcastHint(child) => planLater(child) :: Nil
Copy link
Contributor

@chenghao-intel chenghao-intel Dec 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite obvious, apply method will only make the rules within the object BasicOperators applied, but the data source(Parquet) is an extended strategy defined in another object, planLater means to search the all of the strategies(including the extensions), which is make more sense. That's why it caused exception says No plan for BroadcastHint as apply(child) returns Nil.

case _ => Nil
}
}
Expand Down
7 changes: 7 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/DataFrameJoinSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,5 +120,12 @@ class DataFrameJoinSuite extends QueryTest with SharedSQLContext {

// planner should not crash without a join
broadcast(df1).queryExecution.executedPlan

// SPARK-12275: no physical plan for BroadcastHint in some condition
withTempPath { path =>
df1.write.parquet(path.getCanonicalPath)
val pf1 = sqlContext.read.parquet(path.getCanonicalPath)
assert(df1.join(broadcast(pf1)).count() === 4)
}
}
}