[SPARK-10123][Deploy] Support specifying deploy mode from configuration #10195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #47323 has finished for PR 10195 at commit
|
Contributor
There was a problem hiding this comment.
why not just reuse spark.submit.deployMode? Would that work? Now there's both of these and it's a little confusing.
Contributor
Author
There was a problem hiding this comment.
OK, I see. My previous thought is that spark.submit.deployMode is only for internal use, so I picked another configuration name. I don't have strong opinion on either one, I will change it.
|
Test build #47708 has finished for PR 10195 at commit
|
Contributor
Author
|
Jenkins, retest this please. |
|
Test build #47715 has finished for PR 10195 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please help to review, thanks a lot.