From 1878c700e9a39d612e05bf304a1a873d7a94bbde Mon Sep 17 00:00:00 2001 From: Jeff Zhang Date: Thu, 3 Dec 2015 17:01:15 +0800 Subject: [PATCH 1/3] [SPARK-12120][PYSPARK] Improve exception message when failing to initialize HiveContext in PySpark --- python/pyspark/sql/context.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/python/pyspark/sql/context.py b/python/pyspark/sql/context.py index b05aa2f5c4cd..de09c64923ae 100644 --- a/python/pyspark/sql/context.py +++ b/python/pyspark/sql/context.py @@ -686,9 +686,10 @@ def _ssql_ctx(self): self._scala_HiveContext = self._get_hive_ctx() return self._scala_HiveContext except Py4JError as e: - raise Exception("You must build Spark with Hive. " - "Export 'SPARK_HIVE=true' and run " - "build/sbt assembly", e) + warnings.warn("You must build Spark with Hive. " + "Export 'SPARK_HIVE=true' and run " + "build/sbt assembly") + raise e def _get_hive_ctx(self): return self._jvm.HiveContext(self._jsc.sc()) From b1d404ee174f49a5522e1cfb609e2c08a21713d2 Mon Sep 17 00:00:00 2001 From: Jeff Zhang Date: Tue, 19 Jan 2016 16:06:18 -0800 Subject: [PATCH 2/3] Address review comments --- python/pyspark/sql/context.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/python/pyspark/sql/context.py b/python/pyspark/sql/context.py index de09c64923ae..de1ccaf93cd9 100644 --- a/python/pyspark/sql/context.py +++ b/python/pyspark/sql/context.py @@ -15,6 +15,7 @@ # limitations under the License. # +from __future__ import print_function import sys import warnings import json @@ -686,10 +687,10 @@ def _ssql_ctx(self): self._scala_HiveContext = self._get_hive_ctx() return self._scala_HiveContext except Py4JError as e: - warnings.warn("You must build Spark with Hive. " + print("You must build Spark with Hive. " "Export 'SPARK_HIVE=true' and run " - "build/sbt assembly") - raise e + "build/sbt assembly", file=sys.stderr) + raise def _get_hive_ctx(self): return self._jvm.HiveContext(self._jsc.sc()) From 180fb9bffccf54692666f2f36b74f8de8a977c3f Mon Sep 17 00:00:00 2001 From: Jeff Zhang Date: Tue, 19 Jan 2016 17:50:49 -0800 Subject: [PATCH 3/3] fix style issue --- python/pyspark/sql/context.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/python/pyspark/sql/context.py b/python/pyspark/sql/context.py index de1ccaf93cd9..f3de75a2751e 100644 --- a/python/pyspark/sql/context.py +++ b/python/pyspark/sql/context.py @@ -688,8 +688,8 @@ def _ssql_ctx(self): return self._scala_HiveContext except Py4JError as e: print("You must build Spark with Hive. " - "Export 'SPARK_HIVE=true' and run " - "build/sbt assembly", file=sys.stderr) + "Export 'SPARK_HIVE=true' and run " + "build/sbt assembly", file=sys.stderr) raise def _get_hive_ctx(self):