[SPARK-12021][Streaming][Tests]Fix the potential dead-lock in StreamingListenerSuite #10011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
BTW, there is a similar test in SparkListenerSuite. But SparkContext doesn't hold a lock in |
Member
Author
|
retest this please |
Contributor
|
Thanks for the quick fix, shixiong Happy Thanksgiving |
|
Test build #46800 has finished for PR 10011 at commit
|
Member
Author
|
I saw this issue frequently in several PR builds. I'm going to merge this one because it only touches the test codes and it bores other people. |
asfgit
pushed a commit
that referenced
this pull request
Nov 27, 2015
…ingListenerSuite In StreamingListenerSuite."don't call ssc.stop in listener", after the main thread calls `ssc.stop()`, `StreamingContextStoppingCollector` may call `ssc.stop()` in the listener bus thread, which is a dead-lock. This PR updated `StreamingContextStoppingCollector` to only call `ssc.stop()` in the first batch to avoid the dead-lock. Author: Shixiong Zhu <[email protected]> Closes #10011 from zsxwing/fix-test-deadlock. (cherry picked from commit f57e6c9) Signed-off-by: Shixiong Zhu <[email protected]>
Member
Author
|
@tedyu Happy Thanksgiving, too :) |
Contributor
|
Thanks, @zsxwing, at least it works for my PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In StreamingListenerSuite."don't call ssc.stop in listener", after the main thread calls
ssc.stop(),StreamingContextStoppingCollectormay callssc.stop()in the listener bus thread, which is a dead-lock. This PR updatedStreamingContextStoppingCollectorto only callssc.stop()in the first batch to avoid the dead-lock.