[SPARK-11987] Python API update for ChiSqSelector and QuantileDiscretizer #10007
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SPARK-11987
For
QuantileDiscretizer, I add aQuantileDiscretizerModelin it as a nested class. The reason is aQuantileDiscretizergenerates aBucketizermode, while the latter extends from aJavaTransformerin PySpark rather than aJavaModel, which prevents us transfering java model to python model easily. It also prevents us to call_call_java("get_splits")from outside since it is a private method.I tried to rewrite the
Bucketizerinto aJavaModelin the first time, but it may hurt the current interfaces sinceJavaModelandJavaTransformerhave different ways to setuidand different construction method args__init__(...)