Use local variables for resultIsNulls and argValues.

Author: ueshin

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala

@@ -59,20 +59,16 @@ trait InvokeLike extends Expression with NonSQLExpression {
   def prepareArguments(ctx: CodegenContext): (String, String, String) = {
 
     val resultIsNull = if (needNullCheck) {
-      val resultIsNull = ctx.freshName("resultIsNull")
-      ctx.addMutableState("boolean", resultIsNull, "")
-      resultIsNull
+      ctx.freshName("resultIsNull")
     } else {
       "false"
     }
     val argValues = arguments.map { e =>
-      val argValue = ctx.freshName("argValue")
-      ctx.addMutableState(ctx.javaType(e.dataType), argValue, "")
-      argValue
+      ctx.freshName("argValue")
     }
 
     val argCodes = if (needNullCheck) {
-      val reset = s"$resultIsNull = false;"
+      val reset = s"boolean $resultIsNull = false;"
       val argCodes = arguments.zipWithIndex.map { case (e, i) =>
         val expr = e.genCode(ctx)
         val updateResultIsNull = if (e.nullable) {
@@ -81,6 +77,7 @@ trait InvokeLike extends Expression with NonSQLExpression {
           ""
         }
         s"""
+          ${ctx.javaType(e.dataType)} ${argValues(i)} = ${ctx.defaultValue(e.dataType)};
           if (!$resultIsNull) {
             ${expr.code}
             $updateResultIsNull
@@ -94,11 +91,11 @@ trait InvokeLike extends Expression with NonSQLExpression {
         val expr = e.genCode(ctx)
         s"""
           ${expr.code}
-          ${argValues(i)} = ${expr.value};
+          ${ctx.javaType(e.dataType)} ${argValues(i)} = ${expr.value};
         """
       }
     }
-    val argCode = ctx.splitExpressions(ctx.INPUT_ROW, argCodes)
+    val argCode = argCodes.mkString("\n")
 
     (argCode, argValues.mkString(", "), resultIsNull)
   }