Skip to content

Commit f71e5cc

Browse files
cloud-fanmarmbrus
authored andcommitted
[HOT-FIX] bypass hive test when parse logical plan to json
#10311 introduces some rare, non-deterministic flakiness for hive udf tests, see #10311 (comment) I can't reproduce it locally, and may need more time to investigate, a quick solution is: bypass hive tests for json serialization. Author: Wenchen Fan <[email protected]> Closes #10430 from cloud-fan/hot-fix. (cherry picked from commit 8543997) Signed-off-by: Michael Armbrust <[email protected]>
1 parent 03e523e commit f71e5cc

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -198,6 +198,9 @@ abstract class QueryTest extends PlanTest {
198198
case a: ImperativeAggregate => return
199199
}
200200

201+
// bypass hive tests before we fix all corner cases in hive module.
202+
if (this.getClass.getName.startsWith("org.apache.spark.sql.hive")) return
203+
201204
val jsonString = try {
202205
logicalPlan.toJSON
203206
} catch {
@@ -209,9 +212,6 @@ abstract class QueryTest extends PlanTest {
209212
""".stripMargin, e)
210213
}
211214

212-
// bypass hive tests before we fix all corner cases in hive module.
213-
if (this.getClass.getName.startsWith("org.apache.spark.sql.hive")) return
214-
215215
// scala function is not serializable to JSON, use null to replace them so that we can compare
216216
// the plans later.
217217
val normalized1 = logicalPlan.transformAllExpressions {

0 commit comments

Comments
 (0)