Skip to content

Commit f664aaa

Browse files
MaxGekkHyukjinKwon
authored andcommitted
[SPARK-32599][SQL][TESTS] Check the TEXTFILE file format in HiveSerDeReadWriteSuite
### What changes were proposed in this pull request? - Test TEXTFILE together with the PARQUET and ORC file formats in `HiveSerDeReadWriteSuite` - Remove the "SPARK-32594: insert dates to a Hive table" added by #29409 ### Why are the changes needed? - To improve test coverage, and test other row SerDe - `org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe`. - The removed test is not needed anymore because the bug reported in SPARK-32594 is triggered by the TEXTFILE file format too. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? By running the modified test suite `HiveSerDeReadWriteSuite`. Closes #29417 from MaxGekk/textfile-HiveSerDeReadWriteSuite. Authored-by: Max Gekk <[email protected]> Signed-off-by: HyukjinKwon <[email protected]>
1 parent a418548 commit f664aaa

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveSerDeReadWriteSuite.scala

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ class HiveSerDeReadWriteSuite extends QueryTest with SQLTestUtils with TestHiveS
154154
}
155155
}
156156

157-
Seq("PARQUET", "ORC").foreach { fileFormat =>
157+
Seq("PARQUET", "ORC", "TEXTFILE").foreach { fileFormat =>
158158
test(s"Read/Write Hive $fileFormat serde table") {
159159
// Numeric Types
160160
checkNumericTypes(fileFormat, "TINYINT", 2)
@@ -184,12 +184,4 @@ class HiveSerDeReadWriteSuite extends QueryTest with SQLTestUtils with TestHiveS
184184
checkComplexTypes(fileFormat)
185185
}
186186
}
187-
188-
test("SPARK-32594: insert dates to a Hive table") {
189-
withTable("table1") {
190-
sql("CREATE TABLE table1 (d date)")
191-
sql("INSERT INTO table1 VALUES (date '2020-08-11')")
192-
checkAnswer(spark.table("table1"), Row(Date.valueOf("2020-08-11")))
193-
}
194-
}
195187
}

0 commit comments

Comments
 (0)