Skip to content

Commit f17db39

Browse files
committed
resolve the remaining comments in PR#25295
1 parent 901ff92 commit f17db39

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/OptimizeLocalShuffleReader.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ case class OptimizeLocalShuffleReader(conf: SQLConf) extends Rule[SparkPlan] {
6161
val numExchangeAfter = numExchanges(EnsureRequirements(conf).apply(optimizedPlan))
6262

6363
if (numExchangeAfter > numExchangeBefore) {
64-
logWarning("OptimizeLocalShuffleReader rule is not applied due" +
64+
logDebug("OptimizeLocalShuffleReader rule is not applied due" +
6565
" to additional shuffles will be introduced.")
6666
plan
6767
} else {

sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -229,6 +229,8 @@ class AdaptiveQueryExecSuite
229229
assert(smj.size == 3)
230230
val bhj = findTopLevelBroadcastHashJoin(adaptivePlan)
231231
assert(bhj.size == 2)
232+
checkNumLocalShuffleReaders(adaptivePlan, 1)
233+
// Even with local shuffle reader, the query statge reuse can also work.
232234
val ex = findReusedExchange(adaptivePlan)
233235
assert(ex.size == 1)
234236
}

0 commit comments

Comments
 (0)