Skip to content

Commit f05a908

Browse files
peter-tothdongjoon-hyun
authored andcommitted
[SPARK-52841][SQL][TESTS] Fix PlanStabilitySuite id normalization
### What changes were proposed in this pull request? This PR fixes and id normalization in `PlanStabilitySuite`s and ### Why are the changes needed? Currently if we run a subset of `PlanStabilitySuite`s then it might fail due to plan and expression id conflixts: ``` build/sbt "sql/testOnly *TPCDSV1_4_PlanStabilitySuite" ... [info] - check simplified (tpcds-v1.4/q9) *** FAILED *** (81 milliseconds) ``` This is because the expr id regex doesn't skip and plan id regex doesn't take into account that the plan id is formatted as `id=#...` in `SubqueryExec` nodes. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing UTs + manual subset run. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #51534 from peter-toth/SPARK-52841-fix-planstability-id-normalization. Authored-by: Peter Toth <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
1 parent 63e58d2 commit f05a908

File tree

54 files changed

+6013
-6015
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

54 files changed

+6013
-6015
lines changed

sql/core/src/test/resources/tpcds-plan-stability/approved-plans-modified/q10.sf100/explain.txt

Lines changed: 100 additions & 100 deletions
Large diffs are not rendered by default.

sql/core/src/test/resources/tpcds-plan-stability/approved-plans-modified/q59.sf100/explain.txt

Lines changed: 120 additions & 120 deletions
Large diffs are not rendered by default.

sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q10.sf100/explain.txt

Lines changed: 103 additions & 103 deletions
Large diffs are not rendered by default.

sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q14a.sf100/explain.txt

Lines changed: 138 additions & 138 deletions
Large diffs are not rendered by default.

sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q14a/explain.txt

Lines changed: 138 additions & 138 deletions
Large diffs are not rendered by default.

sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q14b.sf100/explain.txt

Lines changed: 116 additions & 116 deletions
Large diffs are not rendered by default.

sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q14b/explain.txt

Lines changed: 116 additions & 116 deletions
Large diffs are not rendered by default.

sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q16.sf100/explain.txt

Lines changed: 115 additions & 115 deletions
Large diffs are not rendered by default.

sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q2.sf100/explain.txt

Lines changed: 108 additions & 108 deletions
Large diffs are not rendered by default.

sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v1_4/q23a.sf100/explain.txt

Lines changed: 154 additions & 154 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)