Commit f05a908
[SPARK-52841][SQL][TESTS] Fix PlanStabilitySuite id normalization
### What changes were proposed in this pull request?
This PR fixes and id normalization in `PlanStabilitySuite`s and
### Why are the changes needed?
Currently if we run a subset of `PlanStabilitySuite`s then it might fail due to plan and expression id conflixts:
```
build/sbt "sql/testOnly *TPCDSV1_4_PlanStabilitySuite"
...
[info] - check simplified (tpcds-v1.4/q9) *** FAILED *** (81 milliseconds)
```
This is because the expr id regex doesn't skip and plan id regex doesn't take into account that the plan id is formatted as `id=#...` in `SubqueryExec` nodes.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing UTs + manual subset run.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #51534 from peter-toth/SPARK-52841-fix-planstability-id-normalization.
Authored-by: Peter Toth <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>1 parent 63e58d2 commit f05a908
File tree
54 files changed
+6013
-6015
lines changed- sql/core/src/test
- resources
- tpcds-plan-stability
- approved-plans-modified
- q10.sf100
- q59.sf100
- approved-plans-v1_4
- q10.sf100
- q14a.sf100
- q14a
- q14b.sf100
- q14b
- q16.sf100
- q2.sf100
- q23a.sf100
- q23a
- q23b.sf100
- q23b
- q24a.sf100
- q24a
- q24b.sf100
- q24b
- q32.sf100
- q37.sf100
- q40.sf100
- q44.sf100
- q44
- q54.sf100
- q54
- q58.sf100
- q58
- q59.sf100
- q6.sf100
- q64.sf100
- q69.sf100
- q6
- q80.sf100
- q82.sf100
- q85.sf100
- q9.sf100
- q92.sf100
- q94.sf100
- q95.sf100
- q9
- approved-plans-v2_7
- q10a.sf100
- q14.sf100
- q14a.sf100
- q14a
- q14
- q24.sf100
- q24
- q6.sf100
- q64.sf100
- q6
- q80a.sf100
- tpch-plan-stability
- q11
- q15
- q22
- scala/org/apache/spark/sql
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
54 files changed
+6013
-6015
lines changedLines changed: 100 additions & 100 deletions
Large diffs are not rendered by default.
Lines changed: 120 additions & 120 deletions
Large diffs are not rendered by default.
Lines changed: 103 additions & 103 deletions
Large diffs are not rendered by default.
Lines changed: 138 additions & 138 deletions
Large diffs are not rendered by default.
Lines changed: 138 additions & 138 deletions
Large diffs are not rendered by default.
Lines changed: 116 additions & 116 deletions
Large diffs are not rendered by default.
Lines changed: 116 additions & 116 deletions
Large diffs are not rendered by default.
Lines changed: 115 additions & 115 deletions
Large diffs are not rendered by default.
Lines changed: 108 additions & 108 deletions
Large diffs are not rendered by default.
Lines changed: 154 additions & 154 deletions
Large diffs are not rendered by default.
0 commit comments