Skip to content

Commit f04cd67

Browse files
cloud-fansrowen
authored andcommitted
[MINOR] remove dead code in ExpressionEvalHelper
## What changes were proposed in this pull request? This addresses https://github.com/apache/spark/pull/21236/files#r207078480 both #21236 and #21838 add a InternalRow result check to ExpressionEvalHelper and becomes duplicated. ## How was this patch tested? N/A Author: Wenchen Fan <[email protected]> Closes #21958 from cloud-fan/minor.
1 parent d182b3d commit f04cd67

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -105,9 +105,6 @@ trait ExpressionEvalHelper extends GeneratorDrivenPropertyChecks with PlanTestBa
105105
if (expected.isNaN) result.isNaN else expected == result
106106
case (result: Float, expected: Float) =>
107107
if (expected.isNaN) result.isNaN else expected == result
108-
case (result: UnsafeRow, expected: GenericInternalRow) =>
109-
val structType = exprDataType.asInstanceOf[StructType]
110-
result.toSeq(structType) == expected.toSeq(structType)
111108
case (result: Row, expected: InternalRow) => result.toSeq == expected.toSeq(result.schema)
112109
case _ =>
113110
result == expected

0 commit comments

Comments
 (0)