review comments

Sital Kedia · Sital Kedia · commit e884a96a877e · 2017-10-26T16:15:34.000-07:00
diff --git a/core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala b/core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala
@@ -495,6 +495,7 @@ private[spark] class ExecutorAllocationManager(
         s"when it is already pending to be removed!")
       return false
     }
+
     true
   }
 
diff --git a/core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala b/core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala
@@ -227,7 +227,7 @@ class ExecutorAllocationManagerSuite
     assert(numExecutorsToAdd(manager) === 1)
   }
 
-  test("Ignore task end events from completed stages") {
+  test("ignore task end events from completed stages") {
     sc = createSparkContext(0, 10, 0)
     val manager = sc.executorAllocationManager.get
     val stage = createStageInfo(0, 5)

Original file line number	Diff line number	Diff line change
`@@ -495,6 +495,7 @@ private[spark] class ExecutorAllocationManager(`
`495`	`495`	`s"when it is already pending to be removed!")`
`496`	`496`	`return false`
`497`	`497`	`}`
	`498`	`+`
`498`	`499`	`true`
`499`	`500`	`}`
`500`	`501`
Original file line number	Diff line number	Diff line change
`@@ -227,7 +227,7 @@ class ExecutorAllocationManagerSuite`
`227`	`227`	`assert(numExecutorsToAdd(manager) === 1)`
`228`	`228`	`}`
`229`	`229`
`230`		`- test("Ignore task end events from completed stages") {`
	`230`	`+ test("ignore task end events from completed stages") {`
`231`	`231`	`sc = createSparkContext(0, 10, 0)`
`232`	`232`	`val manager = sc.executorAllocationManager.get`
`233`	`233`	`val stage = createStageInfo(0, 5)`