Skip to content

Commit e5cf48d

Browse files
committed
Remove bad retain.
1 parent c9726c2 commit e5cf48d

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

network/common/src/main/java/org/apache/spark/network/protocol/MessageEncoder.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,8 @@ public void encode(ChannelHandlerContext ctx, Message in, List<Object> out) thro
4949

5050
// If the message has a body, take it out to enable zero-copy transfer for the payload.
5151
if (in.body() != null) {
52-
bodyLength = in.body().size();
53-
if (bodyLength > 0) {
54-
in.body().retain();
55-
}
5652
try {
53+
bodyLength = in.body().size();
5754
body = in.body().convertToNetty();
5855
isBodyInFrame = in.isBodyInFrame();
5956
} catch (Exception e) {

network/common/src/test/java/org/apache/spark/network/TestManagedBuffer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public TestManagedBuffer(int len) {
4444
for (int i = 0; i < len; i ++) {
4545
byteArray[i] = (byte) i;
4646
}
47-
this.underlying = new NettyManagedBuffer(Unpooled.wrappedBuffer(byteArray));
47+
this.underlying = new NettyManagedBuffer(Unpooled.wrappedBuffer(byteArray).retain());
4848
}
4949

5050

0 commit comments

Comments
 (0)