address comments

Author: cloud-fan

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala

@@ -417,7 +417,7 @@ case class EqualTo(left: Expression, right: Expression)
       case TypeCheckResult.TypeCheckSuccess =>
         // TODO: although map type is not orderable, technically map type should be able to be used
         // in equality comparison, remove this type check once we support it.
-        if (hasMapType(left.dataType)) {
+        if (left.dataType.existsRecursively(_.isInstanceOf[MapType])) {
           TypeCheckResult.TypeCheckFailure("Cannot use map type in EqualTo, but the actual " +
             s"input type is ${left.dataType.catalogString}.")
         } else {
@@ -427,14 +427,6 @@ case class EqualTo(left: Expression, right: Expression)
     }
   }
 
-  private def hasMapType(dt: DataType): Boolean = dt match {
-    case _: MapType => true
-    case st: StructType => st.map(_.dataType).exists(hasMapType)
-    case a: ArrayType => hasMapType(a.elementType)
-    case udt: UserDefinedType[_] => hasMapType(udt.sqlType)
-    case _ => false
-  }
-
   override def symbol: String = "="
 
   protected override def nullSafeEval(input1: Any, input2: Any): Any = {
@@ -468,7 +460,7 @@ case class EqualNullSafe(left: Expression, right: Expression) extends BinaryComp
       case TypeCheckResult.TypeCheckSuccess =>
         // TODO: although map type is not orderable, technically map type should be able to be used
         // in equality comparison, remove this type check once we support it.
-        if (hasMapType(left.dataType)) {
+        if (left.dataType.existsRecursively(_.isInstanceOf[MapType])) {
           TypeCheckResult.TypeCheckFailure("Cannot use map type in EqualNullSafe, but the actual " +
             s"input type is ${left.dataType.catalogString}.")
         } else {
@@ -478,14 +470,6 @@ case class EqualNullSafe(left: Expression, right: Expression) extends BinaryComp
     }
   }
 
-  private def hasMapType(dt: DataType): Boolean = dt match {
-    case _: MapType => true
-    case st: StructType => st.map(_.dataType).exists(hasMapType)
-    case a: ArrayType => hasMapType(a.elementType)
-    case udt: UserDefinedType[_] => hasMapType(udt.sqlType)
-    case _ => false
-  }
-
   override def symbol: String = "<=>"
 
   override def nullable: Boolean = false