Skip to content

Commit d8b37b2

Browse files
committed
Updated as per the comments by Admin
1 parent bc0bffc commit d8b37b2

File tree

3 files changed

+5
-11
lines changed

3 files changed

+5
-11
lines changed

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -182,18 +182,12 @@ class SqlParser extends StandardTokenParsers with PackratParsers {
182182
val overwrite: Boolean = o.getOrElse("") == "OVERWRITE"
183183
InsertIntoTable(r, Map[String, Option[String]](), s, overwrite)
184184
}
185-
186-
protected lazy val addCache: Parser[LogicalPlan] =
187-
ADD ~ CACHE ~ TABLE ~> ident ~ AS ~ select <~ opt(";") ^^ {
188-
case tableName ~ as ~ s =>
189-
CacheTableAsSelectCommand(tableName,s)
190-
}
191185

192186
protected lazy val cache: Parser[LogicalPlan] =
193-
CACHE ~ TABLE ~> ident ~ opt(AS) ~ opt(select) <~ opt(";") ^^ {
194-
case tableName ~ None ~ None =>
187+
CACHE ~ TABLE ~> ident ~ opt(AS ~ select) <~ opt(";") ^^ {
188+
case tableName ~ None =>
195189
CacheCommand(tableName, true)
196-
case tableName ~ as ~ Some(plan) =>
190+
case tableName ~ Some(as ~ plan) =>
197191
CacheTableAsSelectCommand(tableName,plan)
198192
}
199193

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/commands.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,6 @@ case class DescribeCommand(
7777
}
7878

7979
/**
80-
* Returned for the "ADD CACHE TABLE tableName AS SELECT .." command.
80+
* Returned for the "CACHE TABLE tableName AS SELECT .." command.
8181
*/
8282
case class CacheTableAsSelectCommand(tableName: String, plan: LogicalPlan) extends Command

sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@ private[sql] abstract class SparkStrategies extends QueryPlanner[SparkPlan] {
305305
Seq(execution.ExplainCommand(logicalPlan, plan.output, extended)(context))
306306
case logical.CacheCommand(tableName, cache) =>
307307
Seq(execution.CacheCommand(tableName, cache)(context))
308-
case logical.CacheTableAsSelectCommand(tableName,plan) =>
308+
case logical.CacheTableAsSelectCommand(tableName, plan) =>
309309
Seq(execution.CacheTableAsSelectCommand(tableName, plan))
310310
case _ => Nil
311311
}

0 commit comments

Comments
 (0)