[SPARK-42455][SQL] Rename JDBC option inferTimestampNTZType as preferTimestampNTZ

Similar with #37327, this PR renames the JDBC data source option `inferTimestampNTZType` as `preferTimestampNTZ`

It is simpler and more straightforward. Also, it is consistent with the CSV data source option introduced in #37327,

No, the TimestampNTZ project is not released yet.

UT

Closes #40042 from gengliangwang/inferNTZOption.

Authored-by: Gengliang Wang <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
(cherry picked from commit 8194522)
Signed-off-by: Hyukjin Kwon <[email protected]>

Author: gengliangwang

docs/sql-data-sources-jdbc.md

@@ -365,7 +365,7 @@ logging into the data sources.
     <td>read/write</td>
   </tr>
   <tr>
-    <td><code>inferTimestampNTZType</code></td>
+    <td><code>preferTimestampNTZ</code></td>
     <td>false</td>
     <td>
       When the option is set to <code>true</code>, all timestamps are inferred as TIMESTAMP WITHOUT TIME ZONE.

sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala

@@ -234,9 +234,9 @@ class JDBCOptions(
   val prepareQuery = parameters.get(JDBC_PREPARE_QUERY).map(_ + " ").getOrElse("")
 
   // Infers timestamp values as TimestampNTZ type when reading data.
-  val inferTimestampNTZType =
+  val preferTimestampNTZ =
     parameters
-      .get(JDBC_INFER_TIMESTAMP_NTZ)
+      .get(JDBC_PREFER_TIMESTAMP_NTZ)
       .map(_.toBoolean)
       .getOrElse(SQLConf.get.timestampType == TimestampNTZType)
 }
@@ -301,5 +301,5 @@ object JDBCOptions {
   val JDBC_REFRESH_KRB5_CONFIG = newOption("refreshKrb5Config")
   val JDBC_CONNECTION_PROVIDER = newOption("connectionProvider")
   val JDBC_PREPARE_QUERY = newOption("prepareQuery")
-  val JDBC_INFER_TIMESTAMP_NTZ = newOption("inferTimestampNTZType")
+  val JDBC_PREFER_TIMESTAMP_NTZ = newOption("preferTimestampNTZ")
 }

sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala

@@ -68,7 +68,7 @@ object JDBCRDD extends Logging {
         val rs = statement.executeQuery()
         try {
           JdbcUtils.getSchema(rs, dialect, alwaysNullable = true,
-            isTimestampNTZ = options.inferTimestampNTZType)
+            isTimestampNTZ = options.preferTimestampNTZ)
         } finally {
           rs.close()
         }

sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala

@@ -251,7 +251,7 @@ object JdbcUtils extends Logging with SQLConfHelper {
       try {
         statement.setQueryTimeout(options.queryTimeout)
         Some(getSchema(statement.executeQuery(), dialect,
-          isTimestampNTZ = options.inferTimestampNTZType))
+          isTimestampNTZ = options.preferTimestampNTZ))
       } catch {
         case _: SQLException => None
       } finally {

sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala

@@ -1951,7 +1951,7 @@ class JDBCSuite extends QueryTest with SharedSparkSession {
       } else {
         TimestampType
       }
-      val res = readDf.option("inferTimestampNTZType", inferTimestampNTZ).load()
+      val res = readDf.option("preferTimestampNTZ", inferTimestampNTZ).load()
       checkAnswer(res, Seq(Row(null)))
       assert(res.schema.fields.head.dataType == tsType)
       withSQLConf(SQLConf.TIMESTAMP_TYPE.key -> timestampType) {
@@ -1984,7 +1984,7 @@ class JDBCSuite extends QueryTest with SharedSparkSession {
           DateTimeTestUtils.withDefaultTimeZone(zoneId) {
             // Infer TimestmapNTZ column with data source option
             val res = spark.read.format("jdbc")
-              .option("inferTimestampNTZType", "true")
+              .option("preferTimestampNTZ", "true")
               .option("url", urlWithUserAndPass)
               .option("dbtable", tableName)
               .load()