Skip to content

Commit ccd4959

Browse files
committed
Don't throw exception if client immediately fails
This seems to cause an exception in `DistributedSuite#recover from repeated node failures during shuffle-reduce`. I guess that the exception caused by having an invalid client is handled in a different way than the client creation throwing an exception.
1 parent 9da0bc1 commit ccd4959

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

network/common/src/main/java/org/apache/spark/network/client/SluiceClientFactory.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,8 +129,6 @@ public void initChannel(SocketChannel ch) {
129129
// in the "inactive" state, and someone else simultaneously tried to create another client to
130130
// the same server. This is an error condition, as the first client failed to connect.
131131
throw new IllegalStateException("Client was unset! Must have been immediately inactive.");
132-
} else if (!client.isActive()) {
133-
throw new IllegalStateException("Failed to create active client.");
134132
}
135133
return client;
136134
}

0 commit comments

Comments
 (0)