Skip to content

Commit cafe18d

Browse files
committed
Added missing XSS strip based on comparison to 2.0 branch.
1 parent ffe3e98 commit cafe18d

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

core/src/main/scala/org/apache/spark/ui/jobs/StagesTab.scala

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,8 @@ private[ui] class StagesTab(parent: SparkUI) extends SparkUITab(parent, "stages"
3838

3939
def handleKillRequest(request: HttpServletRequest): Unit = {
4040
if (killEnabled && parent.securityManager.checkModifyPermissions(request.getRemoteUser)) {
41-
val killFlag = Option(request.getParameter("terminate")).getOrElse("false").toBoolean
41+
val killFlag = Option(UIUtils.stripXSS(request.getParameter("terminate")))
42+
.getOrElse("false").toBoolean
4243
// stripXSS is called first to remove suspicious characters used in XSS attacks
4344
val stageId = Option(UIUtils.stripXSS(request.getParameter("id"))).getOrElse("-1").toInt
4445
if (stageId >= 0 && killFlag && progressListener.activeStages.contains(stageId)) {

0 commit comments

Comments
 (0)