The 2 new methods should be private

bersprockets · bersprockets · commit c5e835eb317d · 2018-01-03T18:39:03.000-08:00
diff --git a/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala b/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala
@@ -90,7 +90,7 @@ class HiveExternalCatalogVersionsSuite extends SparkSubmitTestUtils {
     new File(tmpDataDir, name).getCanonicalPath
   }
 
-  def getFileFromUrl(urlString: String, targetDir: String, filename: String): Boolean = {
+  private def getFileFromUrl(urlString: String, targetDir: String, filename: String): Boolean = {
     val conf = new SparkConf
     val securityManager = new SecurityManager(conf)
     val hadoopConf = new Configuration
@@ -110,7 +110,7 @@ class HiveExternalCatalogVersionsSuite extends SparkSubmitTestUtils {
     }
   }
 
-  def getStringFromUrl(urlString: String, encoding: String = "UTF-8"): String = {
+  private def getStringFromUrl(urlString: String, encoding: String = "UTF-8"): String = {
     val outDir = Files.createTempDirectory("string-")
     val filename = "string-out.txt"
 

Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,7 @@ class HiveExternalCatalogVersionsSuite extends SparkSubmitTestUtils {`
`90`	`90`	`new File(tmpDataDir, name).getCanonicalPath`
`91`	`91`	`}`
`92`	`92`
`93`		`- def getFileFromUrl(urlString: String, targetDir: String, filename: String): Boolean = {`
	`93`	`+ private def getFileFromUrl(urlString: String, targetDir: String, filename: String): Boolean = {`
`94`	`94`	`val conf = new SparkConf`
`95`	`95`	`val securityManager = new SecurityManager(conf)`
`96`	`96`	`val hadoopConf = new Configuration`
`@@ -110,7 +110,7 @@ class HiveExternalCatalogVersionsSuite extends SparkSubmitTestUtils {`
`110`	`110`	`}`
`111`	`111`	`}`
`112`	`112`
`113`		`- def getStringFromUrl(urlString: String, encoding: String = "UTF-8"): String = {`
	`113`	`+ private def getStringFromUrl(urlString: String, encoding: String = "UTF-8"): String = {`
`114`	`114`	`val outDir = Files.createTempDirectory("string-")`
`115`	`115`	`val filename = "string-out.txt"`
`116`	`116`