Skip to content

Commit c5add2c

Browse files
committed
address comments.
1 parent db45b4c commit c5add2c

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLViewSuite.scala

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -207,18 +207,18 @@ class SQLViewSuite extends QueryTest with SQLTestUtils with TestHiveSingleton {
207207
}
208208

209209
test("ALTER VIEW: alter a temporary view when a permanent VIEW with same name exists") {
210-
verifyAlterViewWithIdenticalName(isTempAlteredView = true)
210+
alterTempView(isTempAlteredView = true)
211211
}
212212

213213
test("ALTER VIEW: alter a persistent view when a temp VIEW with same name exists") {
214-
verifyAlterViewWithIdenticalName(isTempAlteredView = false)
214+
alterTempView(isTempAlteredView = false)
215215
}
216216

217-
private def verifyAlterViewWithIdenticalName (isTempAlteredView: Boolean) = {
217+
private def alterTempView (isTempAlteredView: Boolean) = {
218218
withView("testView", "default.testView") {
219219
val catalog = spark.sessionState.catalog
220220
val oldViewQuery = "SELECT id FROM jt"
221-
val newViewQuery = "SELECT id, id1 FROM jt"
221+
val newViewQuery = "SELECT id, id1 FROM jt"
222222
sql(s"CREATE VIEW default.testView AS $oldViewQuery")
223223
sql(s"CREATE TEMPORARY VIEW testView AS $oldViewQuery")
224224
if (isTempAlteredView) {
@@ -238,7 +238,7 @@ class SQLViewSuite extends QueryTest with SQLTestUtils with TestHiveSingleton {
238238
assert(tempView.viewOriginalText.isEmpty)
239239

240240
if (isTempAlteredView) {
241-
// View Text of the persistent view default.testView is changed
241+
// View Text of the persistent view default.testView is not changed
242242
assert(persistentView.viewOriginalText == Option(oldViewQuery))
243243
// temp view testView is changed
244244
checkAnswer(

0 commit comments

Comments
 (0)