You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[SPARK-39442][SQL][TESTS] Update PlanStabilitySuite comments with SPARK_ANSI_SQL_MODE
### What changes were proposed in this pull request?
This PR aims to update `PlanStabilitySuite` direction to prevent future mistakes.
1. Add `SPARK_ANSI_SQL_MODE=true` explicitly because Apache Spark 3.3+ test coverage has ANSI and non-ANSI modes. We need to make it sure that both results are synced at the same time.
```
- SPARK_GENERATE_GOLDEN_FILES=1 build/sbt ...
+ SPARK_GENERATE_GOLDEN_FILES=1 build/sbt ...
+ SPARK_GENERATE_GOLDEN_FILES=1 SPARK_ANSI_SQL_MODE=true ...
```
2. The existing commands are human-readable but is not working. So, we had better have more simple command which is *copy-and-pasteable*.
```
- build/sbt "sql/testOnly *PlanStability[WithStats]Suite"
+ build/sbt "sql/testOnly *PlanStability*Suite"
```
### Why are the changes needed?
This will help us update the test results more easily by preventing mistakes.
### Does this PR introduce _any_ user-facing change?
No. This is a dev-only doc.
### How was this patch tested?
Manual review.
Closes#36839 from dongjoon-hyun/SPARK-39442.
Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit d426c10)
Signed-off-by: Dongjoon Hyun <[email protected]>
0 commit comments