Skip to content

Commit bae07e3

Browse files
witgopwendell
authored andcommitted
fix different versions of commons-lang dependency and #746 addendum
Author: witgo <[email protected]> Closes #754 from witgo/commons-lang and squashes the following commits: 3ebab31 [witgo] merge master f3b8fa2 [witgo] merge master 2083fae [witgo] repeat definition 5599cdb [witgo] multiple version of sbt dependency c1b66a1 [witgo] fix different versions of commons-lang dependency
1 parent 4632427 commit bae07e3

File tree

2 files changed

+15
-5
lines changed

2 files changed

+15
-5
lines changed

project/SparkBuild.scala

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -318,6 +318,8 @@ object SparkBuild extends Build {
318318
val excludeFastutil = ExclusionRule(organization = "it.unimi.dsi")
319319
val excludeJruby = ExclusionRule(organization = "org.jruby")
320320
val excludeThrift = ExclusionRule(organization = "org.apache.thrift")
321+
val excludeCommonsLang = ExclusionRule(organization = "commons-lang")
322+
val excludeServletApi = ExclusionRule(organization = "javax.servlet", artifact = "servlet-api")
321323

322324
def sparkPreviousArtifact(id: String, organization: String = "org.apache.spark",
323325
version: String = "0.9.0-incubating", crossVersion: String = "2.10"): Option[sbt.ModuleID] = {
@@ -491,7 +493,7 @@ object SparkBuild extends Build {
491493
javaOptions += "-XX:MaxPermSize=1g",
492494
libraryDependencies ++= Seq(
493495
"org.spark-project.hive" % "hive-metastore" % hiveVersion,
494-
"org.spark-project.hive" % "hive-exec" % hiveVersion,
496+
"org.spark-project.hive" % "hive-exec" % hiveVersion excludeAll(excludeCommonsLang, excludeCommonsLogging),
495497
"org.spark-project.hive" % "hive-serde" % hiveVersion
496498
),
497499
// Multiple queries rely on the TestHive singleton. See comments there for more details.
@@ -564,10 +566,10 @@ object SparkBuild extends Build {
564566
libraryDependencies ++= Seq(
565567
// Exclude rule required for all ?
566568
"org.apache.hadoop" % hadoopClient % hadoopVersion excludeAll(excludeJBossNetty, excludeAsm, excludeOldAsm),
567-
"org.apache.hadoop" % "hadoop-yarn-api" % hadoopVersion excludeAll(excludeJBossNetty, excludeAsm, excludeOldAsm),
568-
"org.apache.hadoop" % "hadoop-yarn-common" % hadoopVersion excludeAll(excludeJBossNetty, excludeAsm, excludeOldAsm),
569-
"org.apache.hadoop" % "hadoop-yarn-client" % hadoopVersion excludeAll(excludeJBossNetty, excludeAsm, excludeOldAsm),
570-
"org.apache.hadoop" % "hadoop-yarn-server-web-proxy" % hadoopVersion excludeAll(excludeJBossNetty, excludeAsm, excludeOldAsm)
569+
"org.apache.hadoop" % "hadoop-yarn-api" % hadoopVersion excludeAll(excludeJBossNetty, excludeAsm, excludeOldAsm, excludeCommonsLogging),
570+
"org.apache.hadoop" % "hadoop-yarn-common" % hadoopVersion excludeAll(excludeJBossNetty, excludeAsm, excludeOldAsm, excludeCommonsLogging),
571+
"org.apache.hadoop" % "hadoop-yarn-client" % hadoopVersion excludeAll(excludeJBossNetty, excludeAsm, excludeOldAsm, excludeCommonsLogging),
572+
"org.apache.hadoop" % "hadoop-yarn-server-web-proxy" % hadoopVersion excludeAll(excludeJBossNetty, excludeAsm, excludeOldAsm, excludeCommonsLogging, excludeServletApi)
571573
)
572574
)
573575

sql/hive/pom.xml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,10 @@
5757
<groupId>commons-logging</groupId>
5858
<artifactId>commons-logging</artifactId>
5959
</exclusion>
60+
<exclusion>
61+
<groupId>commons-lang</groupId>
62+
<artifactId>commons-lang</artifactId>
63+
</exclusion>
6064
</exclusions>
6165
</dependency>
6266
<dependency>
@@ -76,6 +80,10 @@
7680
<groupId>commons-logging</groupId>
7781
<artifactId>commons-logging-api</artifactId>
7882
</exclusion>
83+
<exclusion>
84+
<groupId>commons-lang</groupId>
85+
<artifactId>commons-lang</artifactId>
86+
</exclusion>
7987
</exclusions>
8088
</dependency>
8189
<!-- hive-serde already depends on avro, but this brings in customized config of avro deps from parent -->

0 commit comments

Comments
 (0)