Skip to content

Commit ba766f7

Browse files
committed
initial commit
1 parent 4a3200b commit ba766f7

File tree

3 files changed

+5
-9
lines changed

3 files changed

+5
-9
lines changed

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -816,7 +816,7 @@ case class AlterViewAs(
816816
child: LogicalPlan,
817817
originalText: String,
818818
query: LogicalPlan) extends Command {
819-
override def children: Seq[LogicalPlan] = child :: Nil
819+
override def children: Seq[LogicalPlan] = child :: query :: Nil
820820
}
821821

822822
/**

sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -459,7 +459,7 @@ class ResolveSessionCatalog(val catalogManager: CatalogManager)
459459
case SetTableLocation(ResolvedV1TableIdentifier(ident), partitionSpec, location) =>
460460
AlterTableSetLocationCommand(ident.asTableIdentifier, partitionSpec, location)
461461

462-
case AlterViewAs(ResolvedView(ident, _), originalText, query) =>
462+
case AlterViewAs(ResolvedView(ident, _), originalText, query) if query.resolved =>
463463
AlterViewAsCommand(
464464
ident.asTableIdentifier,
465465
originalText,

sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -266,21 +266,17 @@ case class AlterViewAsCommand(
266266
name: TableIdentifier,
267267
originalText: String,
268268
query: LogicalPlan) extends RunnableCommand {
269+
require(query.resolved)
269270

270271
import ViewHelper._
271272

272273
override def innerChildren: Seq[QueryPlan[_]] = Seq(query)
273274

274275
override def run(session: SparkSession): Seq[Row] = {
275-
// If the plan cannot be analyzed, throw an exception and don't proceed.
276-
val qe = session.sessionState.executePlan(query)
277-
qe.assertAnalyzed()
278-
val analyzedPlan = qe.analyzed
279-
280276
if (session.sessionState.catalog.isTempView(name)) {
281-
alterTemporaryView(session, analyzedPlan)
277+
alterTemporaryView(session, query)
282278
} else {
283-
alterPermanentView(session, analyzedPlan)
279+
alterPermanentView(session, query)
284280
}
285281
Seq.empty[Row]
286282
}

0 commit comments

Comments
 (0)