fixed an issue in star expansion for group by

Author: gatorsmile

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala

@@ -403,6 +403,7 @@ class Analyzer(
         } else {
           val expanded = a.aggregateExpressions.flatMap {
             case s: Star => s.expand(a.child, resolver)
+            case u @ UnresolvedAlias(_: Star, _) => expandStarExpression(u.child, a.child) :: Nil
             case o if containsStar(o :: Nil) => expandStarExpression(o, a.child) :: Nil
             case o => o :: Nil
           }.map(_.asInstanceOf[NamedExpression])

sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala

@@ -547,10 +547,10 @@ class SQLQuerySuite extends QueryTest with SharedSQLContext {
   test("Group By Ordinal: spark.sql.groupByOrdinal=false") {
     withSQLConf(SQLConf.GROUP_BY_ORDINAL.key -> "false") {
       // If spark.sql.groupByOrdinal=false, ignore the position number.
-      // intercept[AnalysisException] {
-      //   sql("SELECT a, sum(b) FROM testData2 GROUP BY 1")
-      // }
-      // // '*' is not allowed to use in the select list when users specify ordinals in group by
+      intercept[AnalysisException] {
+        sql("SELECT a, sum(b) FROM testData2 GROUP BY 1")
+      }
+      // '*' is not allowed to use in the select list when users specify ordinals in group by
       checkAnswer(
         sql("SELECT * FROM testData2 GROUP BY a, b, 1"),
         sql("SELECT * FROM testData2 GROUP BY a, b"))