Fix check of literal.

viirya · viirya · commit ae25004c4548 · 2018-04-24T14:22:57.000Z
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/ExpressionCodegen.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/ExpressionCodegen.scala
@@ -223,7 +223,7 @@ object ExpressionCodegen {
       }
 
       // If it is a nullable expression and `isNull` is not a literal.
-      if (inputVar.nullable && ev.isNull != "true" && ev.isNull != "false") {
+      if (inputVar.nullable && !ev.isNull.isInstanceOf[LiteralValue]) {
         params += ((ev.isNull, s"boolean ${ev.isNull}"))
       }
 

Original file line number	Diff line number	Diff line change
`@@ -223,7 +223,7 @@ object ExpressionCodegen {`
`223`	`223`	`}`
`224`	`224`
`225`	`225`	// If it is a nullable expression and `isNull` is not a literal.
`226`		`- if (inputVar.nullable && ev.isNull != "true" && ev.isNull != "false") {`
	`226`	`+ if (inputVar.nullable && !ev.isNull.isInstanceOf[LiteralValue]) {`
`227`	`227`	`params += ((ev.isNull, s"boolean ${ev.isNull}"))`
`228`	`228`	`}`
`229`	`229`