Skip to content

Commit ae0b55a

Browse files
committed
Checks row length when converting Java arrays to Python rows
1 parent cfdcef7 commit ae0b55a

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

python/pyspark/sql/tests.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -364,6 +364,15 @@ def test_infer_schema_to_local(self):
364364
df3 = self.sqlCtx.createDataFrame(rdd, df.schema)
365365
self.assertEqual(10, df3.count())
366366

367+
def test_create_dataframe_schema_mismatch(self):
368+
input = [Row(a=1)]
369+
rdd = self.sc.parallelize(range(3)).map(lambda i: Row(a=i))
370+
schema = StructType([StructField("a", IntegerType()), StructField("b", StringType())])
371+
df = self.sqlCtx.createDataFrame(rdd, schema)
372+
message = ".*assertion failed: Row length 1 and schema length 2 don't match.*"
373+
with self.assertRaisesRegexp(Exception, message):
374+
df.show()
375+
367376
def test_serialize_nested_array_and_map(self):
368377
d = [Row(l=[Row(a=1, b='s')], d={"key": Row(c=1.0, d="2")})]
369378
rdd = self.sc.parallelize(d)

sql/core/src/main/scala/org/apache/spark/sql/execution/python.scala

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,12 @@ object EvaluatePython {
220220
ArrayBasedMapData(keys, values)
221221

222222
case (c, StructType(fields)) if c.getClass.isArray =>
223-
new GenericInternalRow(c.asInstanceOf[Array[_]].zip(fields).map {
223+
val array = c.asInstanceOf[Array[_]]
224+
assert(
225+
array.length == fields.length,
226+
s"Row length ${array.length} and schema length ${fields.length} don't match"
227+
)
228+
new GenericInternalRow(array.zip(fields).map {
224229
case (e, f) => fromJava(e, f.dataType)
225230
})
226231

0 commit comments

Comments
 (0)