Skip to content

Commit ad9dba8

Browse files
committed
follow comment
1 parent f456207 commit ad9dba8

File tree

3 files changed

+8
-9
lines changed

3 files changed

+8
-9
lines changed

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ParseDriver.scala

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ import org.apache.spark.sql.types.{DataType, StructType}
3333
/**
3434
* Base SQL parsing infrastructure.
3535
*/
36-
abstract class AbstractSqlParser extends ParserInterface with Logging {
36+
abstract class AbstractSqlParser(conf: SQLConf) extends ParserInterface with Logging {
3737

3838
/** Creates/Resolves DataType for a given SQL string. */
3939
override def parseDataType(sqlText: String): DataType = parse(sqlText) { parser =>
@@ -91,16 +91,16 @@ abstract class AbstractSqlParser extends ParserInterface with Logging {
9191
val lexer = new SqlBaseLexer(new UpperCaseCharStream(CharStreams.fromString(command)))
9292
lexer.removeErrorListeners()
9393
lexer.addErrorListener(ParseErrorListener)
94-
lexer.legacy_setops_precedence_enbled = SQLConf.get.setOpsPrecedenceEnforced
95-
lexer.ansi = SQLConf.get.ansiEnabled
94+
lexer.legacy_setops_precedence_enbled = conf.setOpsPrecedenceEnforced
95+
lexer.ansi = conf.ansiEnabled
9696

9797
val tokenStream = new CommonTokenStream(lexer)
9898
val parser = new SqlBaseParser(tokenStream)
9999
parser.addParseListener(PostProcessor)
100100
parser.removeErrorListeners()
101101
parser.addErrorListener(ParseErrorListener)
102-
parser.legacy_setops_precedence_enbled = SQLConf.get.setOpsPrecedenceEnforced
103-
parser.ansi = SQLConf.get.ansiEnabled
102+
parser.legacy_setops_precedence_enbled = conf.setOpsPrecedenceEnforced
103+
parser.ansi = conf.ansiEnabled
104104

105105
try {
106106
try {
@@ -134,12 +134,12 @@ abstract class AbstractSqlParser extends ParserInterface with Logging {
134134
/**
135135
* Concrete SQL parser for Catalyst-only SQL statements.
136136
*/
137-
class CatalystSqlParser(conf: SQLConf) extends AbstractSqlParser {
137+
class CatalystSqlParser(conf: SQLConf) extends AbstractSqlParser(conf) {
138138
val astBuilder = new AstBuilder(conf)
139139
}
140140

141141
/** For test-only. */
142-
object CatalystSqlParser extends AbstractSqlParser {
142+
object CatalystSqlParser extends AbstractSqlParser(SQLConf.get) {
143143
val astBuilder = new AstBuilder(SQLConf.get)
144144
}
145145

sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -600,7 +600,6 @@ class SparkSession private(
600600
* @since 2.0.0
601601
*/
602602
def sql(sqlText: String): DataFrame = {
603-
SparkSession.setActiveSession(this)
604603
val tracker = new QueryPlanningTracker
605604
val plan = tracker.measurePhase(QueryPlanningTracker.PARSING) {
606605
sessionState.sqlParser.parsePlan(sqlText)

sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ import org.apache.spark.sql.types.StructType
3939
/**
4040
* Concrete parser for Spark SQL statements.
4141
*/
42-
class SparkSqlParser(conf: SQLConf) extends AbstractSqlParser {
42+
class SparkSqlParser(conf: SQLConf) extends AbstractSqlParser(conf) {
4343
val astBuilder = new SparkSqlAstBuilder(conf)
4444

4545
private val substitutor = new VariableSubstitution(conf)

0 commit comments

Comments
 (0)