Skip to content

Commit a2b2408

Browse files
committed
addressed review comments
1 parent fa31521 commit a2b2408

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/HashExpressionsSuite.scala

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,11 +137,13 @@ class HashExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
137137
}
138138
val murmur3HashExpr = Murmur3Hash(exprs, 42)
139139
val murmur3HashPlan = GenerateMutableProjection.generate(Seq(murmur3HashExpr))
140-
assert(murmur3HashPlan(wideRow).getInt(0) == 58499324)
140+
val murmursHashEval = Murmur3Hash(exprs, 42).eval(wideRow)
141+
assert(murmur3HashPlan(wideRow).getInt(0) == murmursHashEval)
141142

142143
val hiveHashExpr = HiveHash(exprs)
143144
val hiveHashPlan = GenerateMutableProjection.generate(Seq(hiveHashExpr))
144-
assert(hiveHashPlan(wideRow).getInt(0) == 117331003)
145+
val hiveHashEval = HiveHash(exprs).eval(wideRow)
146+
assert(hiveHashPlan(wideRow).getInt(0) == hiveHashEval)
145147
}
146148

147149
private def testHash(inputSchema: StructType): Unit = {

sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1729,4 +1729,3 @@ class DataFrameSuite extends QueryTest with SharedSQLContext {
17291729
assert(df.filter($"array1" === $"array2").count() == 1)
17301730
}
17311731
}
1732-

0 commit comments

Comments
 (0)