Skip to content

Commit a2544df

Browse files
committed
addressed review comments
1 parent 2c405a1 commit a2544df

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/HashExpressionsSuite.scala

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ class HashExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
125125
new StructType().add("array", arrayOfString).add("map", mapOfString))
126126
.add("structOfUDT", structOfUDT))
127127

128-
test("SPARK-18207: Compute hash for a lot of String expressions") {
128+
test("SPARK-18207: Compute hash for a lot of expressions") {
129129
val N = 1000
130130
val wideRow = new GenericInternalRow(
131131
(1 to N).map(i => UTF8String.fromString(i.toString)).toArray[Any])
@@ -134,8 +134,11 @@ class HashExpressionsSuite extends SparkFunSuite with ExpressionEvalHelper {
134134
val exprs = schema.fields.zipWithIndex.map { case (f, i) =>
135135
BoundReference(i, f.dataType, true)
136136
}
137-
val hashExpr = Murmur3Hash(exprs, 42)
138-
GenerateMutableProjection.generate(Seq(hashExpr))
137+
val murmur3HashExpr = Murmur3Hash(exprs, 42)
138+
GenerateMutableProjection.generate(Seq(murmur3HashExpr))
139+
140+
val hiveHashExpr = HiveHash(exprs)
141+
GenerateMutableProjection.generate(Seq(hiveHashExpr))
139142
}
140143

141144
private def testHash(inputSchema: StructType): Unit = {

0 commit comments

Comments
 (0)