SaveLoad not extending Loader

mengxr · mengxr · commit a0593947822e · 2015-02-07T11:13:14.000-08:00
diff --git a/mllib/src/main/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModel.scala b/mllib/src/main/scala/org/apache/spark/mllib/recommendation/MatrixFactorizationModel.scala
@@ -166,7 +166,7 @@ object MatrixFactorizationModel extends Loader[MatrixFactorizationModel] {
   }
 
   private[recommendation]
-  object SaveLoadV1_0 extends Loader[MatrixFactorizationModel] {
+  object SaveLoadV1_0 {
 
     private val thisFormatVersion = "1.0"
 
@@ -188,7 +188,7 @@ object MatrixFactorizationModel extends Loader[MatrixFactorizationModel] {
       model.productFeatures.toDataFrame("id", "features").saveAsParquetFile(productPath(path))
     }
 
-    override def load(sc: SparkContext, path: String): MatrixFactorizationModel = {
+    def load(sc: SparkContext, path: String): MatrixFactorizationModel = {
       val sqlContext = new SQLContext(sc)
       val (className, formatVersion, metadata) = loadMetadata(sc, path)
       assert(className == thisClassName)

Original file line number	Diff line number	Diff line change
`@@ -166,7 +166,7 @@ object MatrixFactorizationModel extends Loader[MatrixFactorizationModel] {`
`166`	`166`	`}`
`167`	`167`
`168`	`168`	`private[recommendation]`
`169`		`- object SaveLoadV1_0 extends Loader[MatrixFactorizationModel] {`
	`169`	`+ object SaveLoadV1_0 {`
`170`	`170`
`171`	`171`	`private val thisFormatVersion = "1.0"`
`172`	`172`
`@@ -188,7 +188,7 @@ object MatrixFactorizationModel extends Loader[MatrixFactorizationModel] {`
`188`	`188`	`model.productFeatures.toDataFrame("id", "features").saveAsParquetFile(productPath(path))`
`189`	`189`	`}`
`190`	`190`
`191`		`- override def load(sc: SparkContext, path: String): MatrixFactorizationModel = {`
	`191`	`+ def load(sc: SparkContext, path: String): MatrixFactorizationModel = {`
`192`	`192`	`val sqlContext = new SQLContext(sc)`
`193`	`193`	`val (className, formatVersion, metadata) = loadMetadata(sc, path)`
`194`	`194`	`assert(className == thisClassName)`