Skip to content

Commit 9d1ee7c

Browse files
committed
Fix MiMa excludes for ShuffleWriter change
1 parent fd4bb9e commit 9d1ee7c

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

core/src/main/java/org/apache/spark/shuffle/unsafe/UnsafeShuffleWriter.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,6 @@ private void open() throws IOException {
136136
sparkConf);
137137
serArray = new byte[SER_BUFFER_SIZE];
138138
serByteBuffer = ByteBuffer.wrap(serArray);
139-
// TODO: we should not depend on this class from Kryo; copy its source or find an alternative
140139
serOutputStream = serializer.serializeStream(new ByteBufferOutputStream(serByteBuffer));
141140
}
142141

project/MimaExcludes.scala

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,12 @@ object MimaExcludes {
106106
"org.apache.spark.sql.parquet.ParquetTestData$"),
107107
ProblemFilters.exclude[MissingClassProblem](
108108
"org.apache.spark.sql.parquet.TestGroupWriteSupport")
109+
) ++ Seq(
110+
// SPARK-7081 changed ShuffleWriter from a trait to an abstract class and removed some
111+
// unnecessary type bounds in order to fix some compiler warnings that occurred when
112+
// implementing this interface in Java. Note that ShuffleWriter is private[spark].
113+
ProblemFilters.exclude[IncompatibleTemplateDefProblem](
114+
"org.apache.spark.shuffle.ShuffleWriter")
109115
)
110116

111117
case v if v.startsWith("1.3") =>

0 commit comments

Comments
 (0)