Use Java call style and use JavaCode instead of Any.

Author: viirya

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala

@@ -178,26 +178,26 @@ object Block {
   }
 
   // Folds eagerly the literal args into the code parts.
-  private def foldLiteralArgs(parts: Seq[String], args: Seq[Any]): (Seq[String], Seq[Any]) = {
+  private def foldLiteralArgs(parts: Seq[String], args: Seq[Any]): (Seq[String], Seq[JavaCode]) = {
     val codeParts = ArrayBuffer.empty[String]
-    val blockInputs = ArrayBuffer.empty[Any]
+    val blockInputs = ArrayBuffer.empty[JavaCode]
 
     val strings = parts.iterator
     val inputs = args.iterator
     val buf = new StringBuilder(Block.CODE_BLOCK_BUFFER_LENGTH)
 
-    buf append strings.next
+    buf.append(strings.next)
     while (strings.hasNext) {
       val input = inputs.next
       input match {
         case _: ExprValue | _: Block =>
           codeParts += buf.toString
           buf.clear
-          blockInputs += input
+          blockInputs += input.asInstanceOf[JavaCode]
         case _ =>
-          buf append input
+          buf.append(input)
       }
-      buf append strings.next
+      buf.append(strings.next)
     }
     if (buf.nonEmpty) {
       codeParts += buf.toString
@@ -211,7 +211,7 @@ object Block {
  * A block of java code. Including a sequence of code parts and some inputs to this block.
  * The actual java code is generated by embedding the inputs into the code parts.
  */
-case class CodeBlock(codeParts: Seq[String], blockInputs: Seq[Any]) extends Block {
+case class CodeBlock(codeParts: Seq[String], blockInputs: Seq[JavaCode]) extends Block {
   override lazy val exprValues: Set[ExprValue] = {
     blockInputs.flatMap {
       case b: Block => b.exprValues
@@ -223,10 +223,10 @@ case class CodeBlock(codeParts: Seq[String], blockInputs: Seq[Any]) extends Bloc
     val strings = codeParts.iterator
     val inputs = blockInputs.iterator
     val buf = new StringBuilder(Block.CODE_BLOCK_BUFFER_LENGTH)
-    buf append StringContext.treatEscapes(strings.next)
+    buf.append(StringContext.treatEscapes(strings.next))
     while (strings.hasNext) {
-      buf append inputs.next
-      buf append StringContext.treatEscapes(strings.next)
+      buf.append(inputs.next)
+      buf.append(StringContext.treatEscapes(strings.next))
     }
     buf.toString
   }