Skip to content

Commit 91a4741

Browse files
author
Marcelo Vanzin
committed
Tweaks after merge.
1 parent b118b91 commit 91a4741

File tree

4 files changed

+3
-8
lines changed

4 files changed

+3
-8
lines changed

resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/PodTemplateConfigMapStep.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,11 @@ private[spark] class PodTemplateConfigMapStep(
5454
SparkPod(podWithVolume, containerWithVolume)
5555
}
5656

57-
def getAdditionalPodSystemProperties(): Map[String, String] = Map[String, String](
57+
override def getAdditionalPodSystemProperties(): Map[String, String] = Map[String, String](
5858
KUBERNETES_EXECUTOR_PODTEMPLATE_FILE.key ->
5959
(EXECUTOR_POD_SPEC_TEMPLATE_MOUNTPATH + "/" + EXECUTOR_POD_SPEC_TEMPLATE_FILE_NAME))
6060

61-
def getAdditionalKubernetesResources(): Seq[HasMetadata] = {
61+
override def getAdditionalKubernetesResources(): Seq[HasMetadata] = {
6262
require(conf.get(KUBERNETES_EXECUTOR_PODTEMPLATE_FILE).isDefined)
6363
val podTemplateFile = conf.get(KUBERNETES_EXECUTOR_PODTEMPLATE_FILE).get
6464
val podTemplateString = Files.toString(new File(podTemplateFile), StandardCharsets.UTF_8)

resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/PodTemplateConfigMapStepSuite.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ class PodTemplateConfigMapStepSuite extends SparkFunSuite with BeforeAndAfter {
4848
Map.empty,
4949
Map.empty,
5050
Nil,
51-
Seq.empty[String],
5251
Option.empty)
5352
templateFile = Files.createTempFile("pod-template", "yml").toFile
5453
templateFile.deleteOnExit()

resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilderSuite.scala

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -187,15 +187,14 @@ class KubernetesDriverBuilderSuite extends SparkFunSuite {
187187
Map.empty,
188188
Map.empty,
189189
Nil,
190-
Seq.empty[String],
191190
Option.empty)
192191
validateStepTypesApplied(
193192
builderUnderTest.buildFromFeatures(conf),
194193
BASIC_STEP_TYPE,
195194
CREDENTIALS_STEP_TYPE,
196195
SERVICE_STEP_TYPE,
197196
LOCAL_DIRS_STEP_TYPE,
198-
JAVA_STEP_TYPE,
197+
DRIVER_CMD_STEP_TYPE,
199198
TEMPLATE_VOLUME_STEP_TYPE)
200199
}
201200

@@ -296,7 +295,6 @@ class KubernetesDriverBuilderSuite extends SparkFunSuite {
296295
Map.empty,
297296
Map.empty,
298297
Nil,
299-
Seq.empty[String],
300298
Option.empty)
301299
val driverSpec = KubernetesDriverBuilder
302300
.apply(kubernetesClient, sparkConf)
@@ -329,7 +327,6 @@ class KubernetesDriverBuilderSuite extends SparkFunSuite {
329327
Map.empty,
330328
Map.empty,
331329
Nil,
332-
Seq.empty[String],
333330
Option.empty)
334331
val exception = intercept[SparkException] {
335332
KubernetesDriverBuilder

resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesExecutorBuilderSuite.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,6 @@ class KubernetesExecutorBuilderSuite extends SparkFunSuite {
220220
Map.empty,
221221
Map.empty,
222222
Nil,
223-
Seq.empty[String],
224223
Option.empty)
225224
val sparkPod = KubernetesExecutorBuilder
226225
.apply(kubernetesClient, sparkConf)

0 commit comments

Comments
 (0)