Skip to content

Commit 8d04b4c

Browse files
committed
better naming
1 parent 38b1555 commit 8d04b4c

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/PullOutPythonUDFInJoinConditionSuite.scala

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ class PullOutPythonUDFInJoinConditionSuite extends PlanTest {
5252

5353
val unsupportedJoinTypes = Seq(LeftOuter, RightOuter, FullOuter, LeftAnti)
5454

55-
private def comparePlansWithConf(query: LogicalPlan, expected: LogicalPlan): Unit = {
55+
private def comparePlanWithCrossJoinEnable(query: LogicalPlan, expected: LogicalPlan): Unit = {
5656
// AnalysisException thrown by CheckCartesianProducts while spark.sql.crossJoin.enabled=false
5757
val exception = intercept[AnalysisException] {
5858
Optimize.execute(query.analyze)
@@ -75,7 +75,7 @@ class PullOutPythonUDFInJoinConditionSuite extends PlanTest {
7575
testRelationRight,
7676
joinType = Inner,
7777
condition = None).where(pythonUDF).analyze
78-
comparePlansWithConf(query, expected)
78+
comparePlanWithCrossJoinEnable(query, expected)
7979
}
8080

8181
test("left semi join condition with python udf only") {
@@ -87,7 +87,7 @@ class PullOutPythonUDFInJoinConditionSuite extends PlanTest {
8787
testRelationRight,
8888
joinType = Inner,
8989
condition = None).where(pythonUDF).select('a, 'b).analyze
90-
comparePlansWithConf(query, expected)
90+
comparePlanWithCrossJoinEnable(query, expected)
9191
}
9292

9393
test("python udf and common condition") {
@@ -112,7 +112,7 @@ class PullOutPythonUDFInJoinConditionSuite extends PlanTest {
112112
testRelationRight,
113113
joinType = Inner,
114114
condition = None).where(pythonUDF || 'a.attr === 'c.attr).analyze
115-
comparePlansWithConf(query, expected)
115+
comparePlanWithCrossJoinEnable(query, expected)
116116
}
117117

118118
test("pull out whole complex condition with multiple python udf") {
@@ -131,7 +131,7 @@ class PullOutPythonUDFInJoinConditionSuite extends PlanTest {
131131
testRelationRight,
132132
joinType = Inner,
133133
condition = None).where(condition).analyze
134-
comparePlansWithConf(query, expected)
134+
comparePlanWithCrossJoinEnable(query, expected)
135135
}
136136

137137
test("partial pull out complex condition with multiple python udf") {

0 commit comments

Comments
 (0)