Skip to content

Commit 82721ce

Browse files
committed
[SPARK-32741][SQL][FOLLOWUP] Run plan integrity check only for effective plan changes
### What changes were proposed in this pull request? (This is a followup PR of #29585) The PR modified `RuleExecutor#isPlanIntegral` code for checking if a plan has globally-unique attribute IDs, but this check made Jenkins maven test jobs much longer (See [the Dongjoon comment](#29585 (comment)) and thanks, dongjoon-hyun !). To recover running time for the Jenkins tests, this PR intends to update the code to run plan integrity check only for effective plans. ### Why are the changes needed? To recover running time for Jenkins tests. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. Closes #29928 from maropu/PR29585-FOLLOWUP. Authored-by: Takeshi Yamamuro <[email protected]> Signed-off-by: Takeshi Yamamuro <[email protected]>
1 parent 9b88aca commit 82721ce

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ abstract class RuleExecutor[TreeType <: TreeNode[_]] extends Logging {
229229
tracker.foreach(_.recordRuleInvocation(rule.ruleName, runTime, effective))
230230

231231
// Run the structural integrity checker against the plan after each rule.
232-
if (!isPlanIntegral(result)) {
232+
if (effective && !isPlanIntegral(result)) {
233233
val message = s"After applying rule ${rule.ruleName} in batch ${batch.name}, " +
234234
"the structural integrity of the plan is broken."
235235
throw new TreeNodeException(result, message, null)

0 commit comments

Comments
 (0)