File tree Expand file tree Collapse file tree 3 files changed +4
-3
lines changed
main/scala/org/apache/spark
test/scala/org/apache/spark Expand file tree Collapse file tree 3 files changed +4
-3
lines changed Original file line number Diff line number Diff line change @@ -85,7 +85,7 @@ private[spark] object Accumulators extends Logging {
8585 * This global map holds the original accumulator objects that are created on the driver.
8686 * It keeps weak references to these objects so that accumulators can be garbage-collected
8787 * once the RDDs and user-code that reference them are cleaned up.
88- * TODO: Don't use a global map; these should be tied to a SparkContext at the very least .
88+ * TODO: Don't use a global map; these should be tied to a SparkContext (SPARK-13051) .
8989 */
9090 @ GuardedBy (" Accumulators" )
9191 val originals = mutable.Map [Long , WeakReference [Accumulable [_, _]]]()
Original file line number Diff line number Diff line change @@ -61,6 +61,7 @@ case class SparkListenerTaskEnd(
6161 taskType : String ,
6262 reason : TaskEndReason ,
6363 taskInfo : TaskInfo ,
64+ // may be null if the task has failed
6465 @ Nullable taskMetrics : TaskMetrics )
6566 extends SparkListenerEvent
6667
Original file line number Diff line number Diff line change @@ -220,7 +220,7 @@ class InternalAccumulatorSuite extends SparkFunSuite with LocalSparkContext {
220220 rdd.count()
221221 }
222222
223- // TODO: these two tests are incorrect; they don't actually trigger stage retries.
223+ // TODO: these two tests are incorrect; they don't actually trigger stage retries (SPARK-13053) .
224224 ignore(" internal accumulators in fully resubmitted stages" ) {
225225 testInternalAccumulatorsWithFailedTasks((i : Int ) => true ) // fail all tasks
226226 }
@@ -259,7 +259,7 @@ class InternalAccumulatorSuite extends SparkFunSuite with LocalSparkContext {
259259
260260 /**
261261 * Test whether internal accumulators are merged properly if some tasks fail.
262- * TODO: make this actually retry the stage.
262+ * TODO: make this actually retry the stage (SPARK-13053) .
263263 */
264264 private def testInternalAccumulatorsWithFailedTasks (failCondition : (Int => Boolean )): Unit = {
265265 val listener = new SaveInfoListener
You can’t perform that action at this time.
0 commit comments