Skip to content

Commit 7ecb1e6

Browse files
committed
fix
1 parent 590eef5 commit 7ecb1e6

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -45,17 +45,6 @@ case class WindowSpecDefinition(
4545

4646
override def children: Seq[Expression] = partitionSpec ++ orderSpec :+ frameSpecification
4747

48-
/*
49-
* The result of an OffsetWindowFunction is dependent on the frame in which the
50-
* OffsetWindowFunction is executed, the input expression and the default expression. Even when
51-
* both the input and the default expression are foldable, the result is still not foldable due to
52-
* the frame.
53-
*
54-
* Note, the value of foldable is set to false in the trait Unevaluable
55-
*
56-
* override def foldable: Boolean = false
57-
*/
58-
5948
override lazy val resolved: Boolean =
6049
childrenResolved && checkInputDataTypes().isSuccess &&
6150
frameSpecification.isInstanceOf[SpecifiedWindowFrame]
@@ -371,6 +360,17 @@ abstract class OffsetWindowFunction
371360

372361
override def children: Seq[Expression] = Seq(input, offset, default)
373362

363+
/*
364+
* The result of an OffsetWindowFunction is dependent on the frame in which the
365+
* OffsetWindowFunction is executed, the input expression and the default expression. Even when
366+
* both the input and the default expression are foldable, the result is still not foldable due to
367+
* the frame.
368+
*
369+
* Note, the value of foldable is set to false in the trait Unevaluable
370+
*
371+
* override def foldable: Boolean = false
372+
*/
373+
374374
override def nullable: Boolean = default == null || default.nullable || input.nullable
375375

376376
override lazy val frame: WindowFrame = {

0 commit comments

Comments
 (0)