Skip to content

Commit 7d3095d

Browse files
committed
Don't ignore unserializable exception
1 parent b2c2ed1 commit 7d3095d

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,11 @@ private[netty] class NettyRpcEnv(
182182
val remoteAddr = message.receiver.address
183183
if (remoteAddr == address) {
184184
// Message to a local RPC endpoint.
185-
dispatcher.postOneWayMessage(message)
185+
try {
186+
dispatcher.postOneWayMessage(message)
187+
} catch {
188+
case NonFatal(e) => logWarning(e.getMessage, e)
189+
}
186190
} else {
187191
// Message to a remote RPC endpoint.
188192
postToOutbox(message.receiver, OneWayOutboxMessage(serialize(message)))
@@ -506,12 +510,7 @@ private[netty] class NettyRpcEndpointRef(
506510

507511
override def send(message: Any): Unit = {
508512
require(message != null, "Message is null")
509-
try {
510-
nettyEnv.send(RequestMessage(nettyEnv.address, this, message))
511-
} catch {
512-
case NonFatal(e) =>
513-
logWarning(e.getMessage, e)
514-
}
513+
nettyEnv.send(RequestMessage(nettyEnv.address, this, message))
515514
}
516515

517516
override def toString: String = s"NettyRpcEndpointRef(${_address})"

0 commit comments

Comments
 (0)